Changeset 366

Timestamp:

12/09/06 13:22:46 (7 years ago)

Author:

nick

Message:

Return 0 if the node requested for set_moderation doesn't exist

Location:

wiki-toolkit/trunk

Files:

• lib/Wiki/Toolkit.pm (modified) (1 diff)
• lib/Wiki/Toolkit/Store/Database.pm (modified) (2 diffs)
• t/021_moderation.t (modified) (2 diffs)

wiki-toolkit/trunk/lib/Wiki/Toolkit.pm

@@ -259 +259 @@
 sub set_node_moderation {
     my ($self, @args) = @_;
-    $self->store->set_node_moderation( @args );
+    return $self->store->set_node_moderation( @args );
 }
 

wiki-toolkit/trunk/lib/Wiki/Toolkit/Store/Database.pm

@@ -941 +941 @@
         my ($node_id) = $id_sth->fetchrow_array;
     $id_sth->finish;
+
+        # Check we really got an ID
+    unless($node_id) {
+        return 0;
+    }
 
         # Mark it as requiring / not requiring moderation
@@ -1822 +1827 @@
 }
 
+=item B<list_metadata_by_type>
+        List all the currently defined values of the given type of metadata.
+
+        Will only work with the latest moderated version
+
+        # List all of the different metadata values with the type 'category'
+        my @categories = $wiki->list_metadata_by_type('category');
+=cut
+sub list_metadata_by_type {
+        my ($self, $type) = @_;
+
+        return 0 unless $type;
+}
+
+
 =item B<schema_current>
 

wiki-toolkit/trunk/t/021_moderation.t

@@ -7 +7 @@
     plan skip_all => "no backends configured";
 } else {
-    plan tests => ( 85 * scalar @Wiki::Toolkit::TestLib::wiki_info );
+    plan tests => ( 86 * scalar @Wiki::Toolkit::TestLib::wiki_info );
 }
 
@@ -214 +214 @@
     is( 0, $wiki->node_required_moderation("Home"), "node_required_moderation behaves");
     is( 1, $wiki->node_required_moderation("Moderation"), "node_required_moderation behaves");
+
+        # Check that we get 0, not 1 back, when trying to set moderation
+        #  on a node that doesn't exist
+        is( 0, $wiki->set_node_moderation(name=>"NODE THAT DOES NOT EXIST", required=>1), "returns 0 if you set moderation on an unknown node" );
 }