Changeset 437 for wiki-toolkit/trunk/lib/Wiki/Toolkit/Setup/Database.pm

Timestamp:

05/11/08 20:24:34 (4 years ago)

Author:

dom

Message:

Refactor database setup code to support setting up old schema versions and
add wiki_info method to TestLib?, both to facilitiate automated schema upgrade
testing.

Files:

• wiki-toolkit/trunk/lib/Wiki/Toolkit/Setup/Database.pm (modified) (2 diffs)

wiki-toolkit/trunk/lib/Wiki/Toolkit/Setup/Database.pm

@@ -188 +188 @@
 # Is an upgrade to the database required?
 sub get_database_upgrade_required {
-    my ($dbh,$VERSION) = @_;
+    my ($dbh,$new_version) = @_;
 
     # Get the schema version
@@ -194 +194 @@
 
     # Compare it
-    my $new_ver = $VERSION * 100;
-    if($schema_version eq $new_ver) {
+    if($schema_version eq $new_version) {
         # At latest version
         return undef;
+    } elsif ($schema_version eq 'old' or $schema_version < $new_version) {
+        return $schema_version."_to_".$new_version;
     } else {
-        return $schema_version."_to_".$new_ver;
+        die "Aiee! We seem to be trying to downgrade the database schema from $schema_version to $new_version. Aborting.\n";
     }
 }