Ticket #1 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Wiki::Toolkit::Store::Database does not use charset_encode on metadata queries

Reported by: crschmidt@… Owned by: nick
Priority: major Milestone:
Component: wiki-toolkit Version:
Keywords: Cc:

Description

Boston.openguides.org was having queries go through to the database, where the content was passed as iso-8859-1, and because it was not encoded into octets via the $self->charset_encode(), it was being converted to utf-8 in the DBI query somewhere (outside of Wiki::Toolkit's control.)

Function in question is list_nodes_by_metadata. Line I changed now reads:

$sth->execute( $type, $self->charset_encode($value) );

the charset_encode is new. This made it so that nodes actually show up on http://boston.openguides.org/?Category_P%E2tisseries .

Change History

Changed 4 years ago by nick

  • owner changed from dom to nick
  • status changed from new to assigned

There's also encoding needed for metadata values in _find_recent_changes_by_criteria

Changed 4 years ago by nick

  • status changed from assigned to closed
  • resolution set to fixed

Fix applied for both places missing it. All tests still pass :)

Note: See TracTickets for help on using tickets.