Ticket #12 (assigned defect)

Opened 4 years ago

Last modified 2 years ago

New Text::WikiFormat breaks tests with extended links

Reported by: dom Owned by: Kake
Priority: major Milestone:
Component: wiki-toolkit-formatter-usemod Version:
Keywords: hackfestsummer2007-reviewed Cc:

Description

New Text::WikiFormat? (0.76 and 0.78 at least; not 0.71) break the tests for this module. Possibly an API change or bug introduced T::WF?

t/usemod.....................ok 2/25#     Failed test (t/usemod.t at line 107)
#                   '<p>This is an <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">Extended Link</a>.</p>
# <p>This is a lower-case <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">titled extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link_Two]<a href="wiki.pl?action=edit;id=Extended_Link_Two">?</a>">title with leading whitespace</a>.</p>
# <p>This is <a href="wiki.pl?[Another_Link]<a href="wiki.pl?action=edit;id=Another_Link">?</a>">another titled link</a>.</p>
# '
#     doesn't match '(?-xism:<a href="wiki.pl\?Extended_Link">Extended Link</a>)'
#     Failed test (t/usemod.t at line 109)
#                   '<p>This is an <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">Extended Link</a>.</p>
# <p>This is a lower-case <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">titled extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link_Two]<a href="wiki.pl?action=edit;id=Extended_Link_Two">?</a>">title with leading whitespace</a>.</p>
# <p>This is <a href="wiki.pl?[Another_Link]<a href="wiki.pl?action=edit;id=Another_Link">?</a>">another titled link</a>.</p>
# '
#     doesn't match '(?-xism:<a href="wiki.pl\?Extended_Link">extended link</a>)'
#     Failed test (t/usemod.t at line 111)
#                   '<p>This is an <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">Extended Link</a>.</p>
# <p>This is a lower-case <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">titled extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link_Two]<a href="wiki.pl?action=edit;id=Extended_Link_Two">?</a>">title with leading whitespace</a>.</p>
# <p>This is <a href="wiki.pl?[Another_Link]<a href="wiki.pl?action=edit;id=Another_Link">?</a>">another titled link</a>.</p>
# '
#     doesn't match '(?-xism:<a href="wiki.pl\?Extended_Link">titled extended link</a>)'
#     Failed test (t/usemod.t at line 115)
#                   '<p>This is an <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">Extended Link</a>.</p>
# <p>This is a lower-case <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link]<a href="wiki.pl?action=edit;id=Extended_Link">?</a>">titled extended link</a>.</p>
# <p>This is a <a href="wiki.pl?[Extended_Link_Two]<a href="wiki.pl?action=edit;id=Extended_Link_Two">?</a>">title with leading whitespace</a>.</p>
# <p>This is <a href="wiki.pl?[Another_Link]<a href="wiki.pl?action=edit;id=Another_Link">?</a>">another titled link</a>.</p>
# '
#     doesn't match '(?-xism:<a href="wiki.pl\?Extended_Link_Two">)'
# Looks like you failed 4 tests of 25.

Change History

Changed 4 years ago by anonymous

  • priority changed from major to normal
  • type changed from defect to task
  • version changed from svn to 1.0
  • component changed from wiki-toolkit-formatter-usemod to wiki-toolkit-formatter-pod
  • milestone set to 0.70

Changed 4 years ago by anonymous

  • priority changed from normal to trivial
  • type changed from task to defect
  • version 1.0 deleted
  • component changed from wiki-toolkit-formatter-pod to wiki-toolkit-formatter-usemod
  • milestone 0.70 deleted

Changed 4 years ago by dom

  • priority changed from trivial to major

Changed 4 years ago by dom

  • status changed from new to assigned

To narrow things down, this is introuced by Text::WikiFormat? 0.75 -> 0.76.

Changed 4 years ago by dom

The only code changes in 0.76 according to the changelogs are:

  • fixed CAMELCASE linking bug reported by punkish on Perl Monks
  • fixed inadvertent $title reuse in find_link_title()
  • fixed a bug in list detection (find paragraphs correctly)

Changed 3 years ago by dom

  • owner changed from dom to Nobody
  • status changed from assigned to new

Changed 3 years ago by Kake

  • keywords hackfestsummer2007-reviewed added
  • owner changed from Nobody to Kake
  • status changed from new to assigned

Decision at hackfest: Kake hasn't looked at this yet, so should do so before any more action.

Changed 2 years ago by dom

This is http://rt.cpan.org//Ticket/Display.html?id=34402 (bug in Text::WikiFormat?). Thanks to Jess Robinson for the diagnosis.

Changed 2 years ago by dom

0.21 works around this by SKIPping the affected tests.

Note: See TracTickets for help on using tickets.