undefined charset if dbh is passed to new storage

[dom]

[from  http://rt.cpan.org/Public/Bug/Display.html?id=26761]

Wiki::Toolkit::Store::Pg->new( dbh => $dbh, charset => 'utf-8' );

In the above code, if you either specify charset or not it is ignored and undefined so charset_encode/charset_decode functions don't have anything to work with.

This is the chage i've made to Wiki::Toolkit::Store::Database version 0.27 as a quick fix. I'm not sure if this is the best fix though.

if ( $args{dbh} ) {
$self->{_dbh} = $args{dbh};
$self->{_external_dbh} = 1; # don't disconnect at DESTROY time
+ $self->{_charset} = $args{charset} || "iso-8859-1";
} else {
die "Must supply a dbname" unless defined $args{dbname};

Thank you.

[dom]

Code should have been:

if ( $args{dbh} ) {
$self->{_dbh} = $args{dbh};
$self->{_external_dbh} = 1; # don't disconnect at DESTROY time
+ $self->{_charset} = $args{charset} || "iso-8859-1";
} else {
die "Must supply a dbname" unless defined $args{dbname};

[dom]

(In [481]) Configure charset correctly when passing in an existing $dbh (fixes #24)