Ticket #41 (new defect)

Opened 23 months ago

Last modified 12 months ago

Recent Changes includes ancient edits if you don't have minor edits switched on

Reported by: kake Owned by: Nobody
Priority: critical Milestone:
Component: wiki-toolkit Version: 0.75
Keywords: Cc:

Description

I think this bug was probably introduced when I last overhauled the Recent Changes code; the test suite seems to have been inadequate.

If you list the Recent Changes with minor edits excluded, then it returns not only the most recent changes, but also some more ancient changes to nodes that have been edited recently. To reproduce this, just look at a reasonably active OpenGuides? install with minor edits excluded.

Attachments

test_for_metadata_wasnt_recent_changes.diff (5.2 kB) - added by bob 13 months ago.
diff which adds tests which exposes this bug.

Change History

Changed 23 months ago by dom

  • owner changed from dom to Nobody

Changed 23 months ago by dom

  • priority changed from major to critical

Changed 22 months ago by dom

This is triggered by the following code in OpenGuides?:

            $criteria{metadata_was} = { edit_type => "Normal edit" }
              unless $minor_edits;
            my @rc = $self->{wiki}->list_recent_changes( %criteria );

Changed 21 months ago by dom

  • version changed from svn to 0.75

Changed 13 months ago by bob

diff which adds tests which exposes this bug.

Changed 13 months ago by bob

i also have a fix for openguides to use is instead of was.

Changed 12 months ago by dom

(In [503]) add more recent changes tests (references #41)

Note: See TracTickets for help on using tickets.