Ticket #41 (closed defect: fixed)

Opened 6 years ago

Last modified 2 years ago

Recent Changes includes ancient edits if you don't have minor edits switched on

Reported by: kake Owned by: Nobody
Priority: critical Milestone:
Component: wiki-toolkit Version: 0.75
Keywords: Cc:

Description

I think this bug was probably introduced when I last overhauled the Recent Changes code; the test suite seems to have been inadequate.

If you list the Recent Changes with minor edits excluded, then it returns not only the most recent changes, but also some more ancient changes to nodes that have been edited recently. To reproduce this, just look at a reasonably active OpenGuides? install with minor edits excluded.

Attachments

test_for_metadata_wasnt_recent_changes.diff (5.2 KB) - added by bob 5 years ago.
diff which adds tests which exposes this bug.

Change History

comment:1 Changed 6 years ago by dom

  • Owner changed from dom to Nobody

comment:2 Changed 6 years ago by dom

  • Priority changed from major to critical

comment:3 Changed 6 years ago by dom

This is triggered by the following code in OpenGuides?:

            $criteria{metadata_was} = { edit_type => "Normal edit" }
              unless $minor_edits;
            my @rc = $self->{wiki}->list_recent_changes( %criteria );

comment:4 Changed 6 years ago by dom

  • Version changed from svn to 0.75

Changed 5 years ago by bob

diff which adds tests which exposes this bug.

comment:5 Changed 5 years ago by bob

i also have a fix for openguides to use is instead of was.

comment:6 Changed 5 years ago by dom

(In [503]) add more recent changes tests (references #41)

comment:7 Changed 2 years ago by kake

  • Status changed from new to closed
  • Resolution set to fixed

(In [533]) Fixed SQL for recent changes when metadata_was/metadata_wasnt parameter supplied (fixes #41). Also removed bogus test after checking with bob (who wrote it).

Note: See TracTickets for help on using tickets.